Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Forwarder usage does not handle fees #557

Open
dekz opened this issue Jul 4, 2019 · 0 comments
Open

Forwarder usage does not handle fees #557

dekz opened this issue Jul 4, 2019 · 0 comments
Labels
bug Something isn't working high priority

Comments

@dekz
Copy link
Member

dekz commented Jul 4, 2019

When using the Forwarder fee orders are never used, so any order with ZRX fees will fail.

0xProject/0x-launch-kit#22

            if (isMarketBuyForwarder) {
                txHash = await contractWrappers.forwarder.marketBuyOrdersWithEthAsync(
                    ordersToFill,
                    amount,
                    ethAccount,
                    ethAmountRequired,
                    [], // no fee orders
                    0,
                    ZERO_ADDRESS,
                    getTransactionOptions(gasPrice),
                );
            }
@dekz dekz added bug Something isn't working high priority labels Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant