Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Run more tests in the browser #831

Open
albrow opened this issue Jun 10, 2020 · 0 comments
Open

Run more tests in the browser #831

albrow opened this issue Jun 10, 2020 · 0 comments
Labels
browser tech debt A code quality issue is not urgent but could cause problems down the line if not addressed

Comments

@albrow
Copy link
Contributor

albrow commented Jun 10, 2020

There are some tests which we currently don't run in the browser (they are excluded by build tags) but should be able to. For example, look at the orderwatch package. It looks like one reason for this is that wasmbrowsertest doesn't support the --serial flag. To workaround this we could potentially use an environment variable instead of a flag. Another reason for this historically has been the inability to declare certain globals that Mesh depends on in the browser. However, as of #811 we have a way to do this.

@albrow albrow added browser tech debt A code quality issue is not urgent but could cause problems down the line if not addressed labels Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser tech debt A code quality issue is not urgent but could cause problems down the line if not addressed
Projects
None yet
Development

No branches or pull requests

1 participant