Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Clean up order validation pipeline #837

Open
albrow opened this issue Jun 15, 2020 · 0 comments
Open

Clean up order validation pipeline #837

albrow opened this issue Jun 15, 2020 · 0 comments
Labels
tech debt A code quality issue is not urgent but could cause problems down the line if not addressed

Comments

@albrow
Copy link
Contributor

albrow commented Jun 15, 2020

Our process for validating incoming orders is complicated, and the code that does so (meshSpecificOrderValidation, onchainOrderValidation, orderwatch.Watcher.add, etc) is spread out and somewhat inconsistent. This is largely a relic of different people contributing to different parts of the pipeline and changing requirements over time.

We should take the opportunity to clean up the validation pipeline and use consistent rules for all the functions involved. For example, we should always return the same values from each function: orders that are definitely valid/accepted, those that are definitely invalid/rejected, and orders which are possibly valid and should continue through the pipeline.

@albrow albrow added the tech debt A code quality issue is not urgent but could cause problems down the line if not addressed label Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech debt A code quality issue is not urgent but could cause problems down the line if not addressed
Projects
None yet
Development

No branches or pull requests

1 participant