Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deployed on WordPress VIP, duplicate plugin update messages are visible in the network admin #160

Open
1 task done
chriseagle opened this issue Apr 18, 2024 · 0 comments · May be fixed by #172
Open
1 task done
Labels

Comments

@chriseagle
Copy link

Describe the bug

On the network plugin screen, 2 update messages appear for plugins which have an update available.

From VIP Support

We have potentially identified the source of the duplication. We do not rely on core's notice since users cannot update plugins from the plugin dashboard but we add the notification manually here:

https://github.com/Automattic/vip-go-mu-plugins/blob/develop/codebase-manager/plugins/plugins-manager.php#L17

And at the same time it seems like 10up is doing the same here:
https://github.com/wpcomvip/gus-wp/blob/trunk-built/plugins/10up-experience/includes/classes/Plugins/Plugins.php#L181

Steps to Reproduce

n/a

Screenshots, screen recording, code snippet

Screenshot 2024-04-18 at 09 01 21

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant