Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --hot option breaks when used with useScriptModules #428

Open
1 task done
nicholasio opened this issue Oct 23, 2024 · 1 comment
Open
1 task done

The --hot option breaks when used with useScriptModules #428

nicholasio opened this issue Oct 23, 2024 · 1 comment

Comments

@nicholasio
Copy link
Member

Describe the bug

The new modules support does not work well with HMR. Ideally we get it to work with modules or at the very least keep it working for CJS modules.

Steps to Reproduce

  1. Set useScriptModules to true
  2. Run 10up-toolkit watch --hot

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nicholasio nicholasio changed the title --hot break when used with useScriptModules` The --hot option breaks when used with useScriptModules` Oct 23, 2024
@nicholasio nicholasio changed the title The --hot option breaks when used with useScriptModules` The --hotoption breaks when used with useScriptModules` Oct 23, 2024
@nicholasio nicholasio changed the title The --hotoption breaks when used with useScriptModules` The --hot option breaks when used with useScriptModules Oct 23, 2024
@smachi
Copy link

smachi commented Nov 11, 2024

+1

It throws an error:

[ReactRefreshPlugin] Hot Module Replacement (HMR) is not enabled! React Refresh requires HMR to function properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants