New component: Video #225
Draft
New component: Video #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +11.6 kB (+22%) 🚨 Total Size: 65.2 kB
|
1 task
|
One issue that has come up in testing of this component on a client project is that sometimes people may upload videos that are too large, either by resolution or by filesize. It would be good to have a way to warn if the uploaded video dimensions are too large, or the filesize is too large. |
1 failed test on run #681 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| IconPicker > allows the user to use the post picker to change an icon and displays it |
Screenshots
Video
|
|
Review all test suite changes for PR #225 ↗︎
benlk
commented
Oct 20, 2023
components/video/readme.md
Outdated
| } | ||
| ``` | ||
|
|
||
| If you'd like to make an Inspector control for this video, use `VideoControl` instead: |
There was a problem hiding this comment.
Add demonstration here.
…ponents into feat/220-video-components
|
Items to copy from the client project:
Items to consider adding:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds a
Videocomponent to matchImage, and aVideoControlcomponent to simplify uploading and other aspects of the video.Adds incomplete documentation for the new components.
Outstanding questions:
posterimages?<track>? If so, this may need to be paired with PHP code allowingvttfiles to be uploaded to WordPress. WordPress' core Video Block allows subtitles; we should borrow from their subtitle components where possible. https://wordpress.org/documentation/article/video-block/autoplay,loop,muted,controls, andplaysinline?VideoControls?allowedTypesof specific MIME types that are allowed for upload, instead of defaulting to the wide-open"video"or the more-limited[ 'video/webm', 'video/mp4']?Closes #220
How to test the Change
Testing suggestions are welcome.
VideoandVideoControlcomponents to a block; make sure they workChangelog Entry
Credits
Props @username, @username2, ...
Checklist: