Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image component uploading state #273

Open
1 task done
johnwatkins0 opened this issue Nov 7, 2023 · 2 comments
Open
1 task done

Image component uploading state #273

johnwatkins0 opened this issue Nov 7, 2023 · 2 comments
Assignees
Labels
[Component] Image Good First Issue Good for newcomers [Type] Enhancement New feature or request

Comments

@johnwatkins0
Copy link
Member

johnwatkins0 commented Nov 7, 2023

Is your enhancement related to a problem? Please describe.

Currently, the Image component does not change state when an image is uploading. So if you upload a large image, there may be several seconds where nothing is happening. As a user this can be confusing. I suggest adding callback props to the component, one that runs when an upload starts and another that runs when an upload finishes. This way our components that use the Image component can provide an upload state. Alternatively, the Image component could handle that state itself.

https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/media-placeholder/README.md#onfilespreupload onFilesPreUpload is probably useful.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fabiankaegy fabiankaegy added [Type] Enhancement New feature or request [Component] Image Good First Issue Good for newcomers labels Jan 29, 2024
@IayushCoderJOD
Copy link

@johnwatkins0 @fabiankaegy Can you assign me this issue?

@Sidsector9
Copy link
Member

@IayushCoderJOD the issue has been assigned to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Image Good First Issue Good for newcomers [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants