Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating screenshots of the plugin #310

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Updating screenshots of the plugin #310

wants to merge 3 commits into from
+2 −2

Conversation

gabriel-glo
Copy link
Contributor

@gabriel-glo gabriel-glo commented Aug 1, 2024 •
edited
Loading

Description of the Change

Updated screenshots for:

  • podcast taxonomy setup
  • editor view for the podcast block

Still need to add and incorporate screenshots from #264

Closes #213 #264

How to test the Change

Visible in Readme.md

Changelog Entry

Added - New screenshots in Readme.md

Credits

Props @username, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@gabriel-glo gabriel-glo self-assigned this Aug 1, 2024
@gabriel-glo gabriel-glo requested a review from jeffpaul as a code owner August 1, 2024 14:06
@gabriel-glo gabriel-glo linked an issue Aug 1, 2024 that may be closed by this pull request
Update documentation graphics #213
Open
1 task
@github-actions github-actions bot added this to the 1.8.1 milestone Aug 1, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 1, 2024
jeffpaul
jeffpaul reviewed Aug 1, 2024
View reviewed changes
.wordpress-org/screenshot-1.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to update the descriptions here:

simple-podcasting/readme.txt

Lines 108 to 111 in 35f5973

1. Podcast in classic editor
2. Podcast block in the WordPress block editor (aka Gutenberg)
3. Creating a podcast
4. Podcast feed
and here: https://github.com/10up/simple-podcasting/tree/develop?tab=readme-ov-file#submit-your-podcast-feed-to-apple-podcasts as this changes from showing in Classic Editor to showing in the Block Editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that I'm fine to focus more on the Block Editor than Classic Editor, no concerns there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabriel-glo any chance you can look into these updates over the next month or so and get this ready for merge?

Copy link
Member

@Sidsector9 Sidsector9 Sep 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul we are removing the screenshot for classic editor and replacing it with screenshot of the Podcast block enhancement? But we already have screenshot-2 for the Podcast block.

Do you think we should replace screenshot-2 instead of classic editor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 intent was to update per #213 #264 as well as #264.

@dkotter dkotter modified the milestones: 1.8.1, 1.9.0 Aug 21, 2024
@jeffpaul jeffpaul linked an issue Aug 21, 2024 that may be closed by this pull request
Add screenshots for recent enhancements #264
Open
4 tasks
@Sidsector9 Sidsector9 requested a review from a team as a code owner September 6, 2024 10:29
@Sidsector9 Sidsector9 requested review from peterwilsoncc and removed request for a team September 6, 2024 10:29
@dkotter dkotter modified the milestones: 1.9.0, Future Release Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 left review comments

@jeffpaul jeffpaul jeffpaul left review comments

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc peterwilsoncc is a code owner automatically assigned from 10up/open-source-practice

At least 1 approving review is required to merge this pull request.

Assignees

@gabriel-glo gabriel-glo

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.

Add screenshots for recent enhancements Update documentation graphics
4 participants
@gabriel-glo @jeffpaul @Sidsector9 @dkotter