Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sniff code in the annotation message. #3

Open
dinhtungdu opened this issue Jun 3, 2021 · 1 comment
Open

Show sniff code in the annotation message. #3

dinhtungdu opened this issue Jun 3, 2021 · 1 comment
Assignees
@kmgalanakis
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone
1.8.0

Comments

@dinhtungdu
Copy link

No description provided.

@dinhtungdu dinhtungdu added the type:enhancement New feature or request. label Jun 3, 2021
@jeffpaul jeffpaul added this to the 1.4.0 milestone Jun 14, 2022
@peterwilsoncc peterwilsoncc modified the milestones: 1.4.0, Future Release Nov 23, 2022
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jun 12, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Jun 12, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 1.6.0 Jun 12, 2023
@kmgalanakis kmgalanakis self-assigned this Aug 17, 2023
@kmgalanakis
Copy link

This would be a really nice addition but even though it should display the Sniff name (currently defined as the code property of the problem matcher, it's not. The problem matcher properly picks up the Sniff name, I verified that by serving that in the annotation instead of the error message. Apparently, the code property is not included in the annotation.

Fortunately, this is not something limited to our actions. The same thing applies to other actions I tried, such as this one.

Let's keep an eye on this.

@dkotter dkotter modified the milestones: 1.6.0, 1.7.0 Aug 29, 2023
@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.8.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmgalanakis kmgalanakis

Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Open Source Practice
Status: To Do
Milestone
1.8.0
Development

No branches or pull requests
5 participants
@peterwilsoncc @dkotter @kmgalanakis @jeffpaul @dinhtungdu