Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think the 'len' type of the coap_option_t structure should be uint16_t. #47

Open
neo1seok opened this issue Nov 28, 2019 · 0 comments

Comments

@neo1seok
Copy link

neo1seok commented Nov 28, 2019

Hi!!
Your source is simple and tidy, I'm checking to apply. But I have a part to comment.

If the delta value in the options section of coap is 13 or 14, the option type may be greater than 255. However, the 'len' type of the structure 'coap_option_t' is set to 'uint8_t', so it should be applied to uint16_t.

I think this type doesn't exceed 1 byte. Onem2m is defined with more than 256 values ​​in iot platform. If you define it as 2 bytes, I think it can be extended.

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant