Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile_sector() fails to handle case "b" #280

Open
Tilmon opened this issue Jul 1, 2024 · 0 comments
Open

profile_sector() fails to handle case "b" #280

Tilmon opened this issue Jul 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Tilmon
Copy link
Collaborator

Tilmon commented Jul 1, 2024

This reprex shows the output of tiltIndicator is as expected but not tiltIndicatorAfter.


(Original)

Dear @maurolepore ,

I detected another case of NAs that seems to not be preserved in sector_profile(). That is the case where clustered == b in this reprex. I.e., in the sector_profile product-level output you shared, the output lacks those ep_product that don't have any results because they miss the tilt_sector.

I detected a few examples by comparing results from emission_profile and sector_profile. One example is the companies_id == "%ef%bb%bfmathias-maschinenhandel-laserservice_00000005053892-001"

You can see in the two screenshots below that in the emission_profile() the company contains 7 ep_products, but in sector_profile only 1.

Emission Profile
Image

Sector Profile
Image

Note: The ep_products without any results should be preserved on product-level for sector_profile(), similar as it's done for emission_profile().

The data sources I'm referring to are the product-level outputs from Release v0.0.0.9003

@maurolepore maurolepore changed the title Please check why NAs for ep_products without tilt_sector are not preserved in sector_profile() profile_sector() fails to handle case "b" Jul 2, 2024
@maurolepore maurolepore added the bug Something isn't working label Jul 2, 2024
@maurolepore maurolepore transferred this issue from 2DegreesInvesting/tiltIndicator Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants