Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't round duration #29

Open
powellnorma opened this issue Oct 6, 2024 · 0 comments · May be fixed by #31
Open

Don't round duration #29

powellnorma opened this issue Oct 6, 2024 · 0 comments · May be fixed by #31

Comments

@powellnorma
Copy link
Contributor

powellnorma commented Oct 6, 2024 •
edited
Loading

If the title changes every second, this watcher sends data to the server, but the duration is 0.

Reproducible via:

let count = 0;

function updateTitle() {
  count++;
  document.title = `Count: ${count}`;
}

setInterval(updateTitle, 1000);

Hm ok, the issue seems to not be related to rounding, but to duration of last event not being updated before new one get's created, so it stays at initial value (zero):

awatcher/watchers/src/report_client.rs

Line 122 in a045780

duration: TimeDelta::zero(),

@powellnorma powellnorma linked a pull request Oct 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

x11: send end of previous active window powellnorma/awatcher
1 participant
@powellnorma