Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App names incorrect #261

Open
pirelle opened this issue Jul 28, 2023 · 2 comments
Open

App names incorrect #261

pirelle opened this issue Jul 28, 2023 · 2 comments

Comments

@pirelle
Copy link

pirelle commented Jul 28, 2023

Hi! In the link below, application name is taken from the migration file path, and then compared with self.migration_loader.disk_migrations which is wrong, since app name can be defined in some_app/apps.py::DefaultConfig::label and can have any name

https://github.com/3YOURMIND/django-migration-linter/blob/3503367f1fcb34e633577cf70df9ab037d1f394c/django_migration_linter/migration_linter.py#L387C42-L387C42
@pirelle pirelle mentioned this issue Aug 3, 2023
Open
@phillipuniverse
Copy link
Contributor

@pirelle this is the same as #248 and #249 right?

@pirelle
Copy link
Author

pirelle commented Aug 15, 2023 •
edited
Loading

@pirelle this is the same as #248 and #249 right?

Yes, you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillipuniverse @pirelle