Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include undetermined amino acids and handle gaps #99

Open
hnguyentt opened this issue Feb 13, 2024 · 0 comments
Open

Include undetermined amino acids and handle gaps #99

hnguyentt opened this issue Feb 13, 2024 · 0 comments

Comments

@hnguyentt
Copy link

hnguyentt commented Feb 13, 2024

Hello, thanks for your excellent work!

I have some questions about the residues you excluded and included in the protein sequence. I found this code:

def remove_non_residue(sequence: str) -> str:
    return "".join([s for s in sequence if s in "ARNDCQEGHILKMFPSTWYVU"])
  1. You included 21 amino acids. Why did you include Selenocysteine (U) - a rare amino acid but not Pyrrolysine (O), also a rare amino main?
  2. Why didn't you take into account the letter B (Aspartic acid | Asparagine), J (Leucine | Isoleucine), Z (Glutamic acid | Glutamine)? If we remove these letters the sequence length is not corresponding to the real sequence length.
  3. Why didn't you take into account letter X of undetermined residue?
  4. Besides, we have - to denote gap of indeterminate length. Do you have any plan to process this piece of information in the future?

Image from iOS

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant