Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse by authority and back does not show the previous result #22

Open
floriangantner opened this issue Apr 14, 2023 · 1 comment · May be fixed by #25
Open

Browse by authority and back does not show the previous result #22

floriangantner opened this issue Apr 14, 2023 · 1 comment · May be fixed by #25
Assignees
@atarix83
Labels
bug

Comments

@floriangantner
Copy link

Describe the bug
Browsing after some Item with authority does not return to the previous state.

To Reproduce
Steps to reproduce the behavior:

  1. Configure some Browse Option which considers authority values.
  2. e.g. visit Demo: https://dspacecris7.4science.cloud/browse/author
  3. Select some browse entry with value and authority , e.g. https://dspacecris7.4science.cloud/browse/author?value=Bollini,%20Andrea&authority=092b59e8-8159-4e70-98b5-93ec60bd3431

Screenshot 2023-04-14 at 17-43-14 DSpace Angular Auflistung nach Autor in

Screenshot 2023-04-14 at 17-43-25 DSpace Angular Auflistung nach Autor in

  1. Press the Back buttons. the URL changes:
  2. Not the previous results are shown, but some corrupt list of all entities. The URL is now: https://dspacecris7.4science.cloud/browse/author?authority=092b59e8-8159-4e70-98b5-93ec60bd3431&bbm.page=1
    Screenshot 2023-04-14 at 17-43-33 DSpace Angular Auflistung nach Autor in

Expected behavior
We expect the route to be updated and the parameter authority to be removed.
The corresponding line is this:

dspace-angular/src/app/shared/browse-by/browse-by.component.ts

Line 192 in 4ece4cd

this.paginationService.updateRoute(this.paginationConfig.id, {page: page}, {[this.paginationConfig.id + '.return']: null, value: null, startsWith: null});

Related work
Link to any related tickets or PRs here.
@floriangantner floriangantner linked a pull request Apr 28, 2023 that will close this issue
Open
6 tasks
@floriangantner
Copy link
Author

still reproduce-able in current 2023.02.xx releases
f.e. fpr 2023.02.04 currently see https://dspacecris-demo.4science.cloud/browse/author?value=Bollini,%20Andrea&authority=092b59e8-8159-4e70-98b5-93ec60bd3431 and press back to results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atarix83 atarix83

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix authority when browsing back uniba-ub/dspace-angular
2 participants
@atarix83 @floriangantner