From 8d95bd895b4718fa95c8a4dc82754b63230b0f6a Mon Sep 17 00:00:00 2001 From: Onurcankaratay Date: Fri, 15 Nov 2024 10:07:59 +0300 Subject: [PATCH 1/4] ensure React Tooltip appears on disabled buttons --- .../static/scss/encoded/_bootstrap-theme-overrides.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss index 8b8043135e..e4f516ac95 100644 --- a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss +++ b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss @@ -24,6 +24,11 @@ vertical-align: middle; transform: translate(0,-0.45px); } + + &:disabled { + cursor: default; + pointer-events: auto; + } } .btn.btn-lg { From a925c6110a75231bdec20c04fc03e342f64e54fe Mon Sep 17 00:00:00 2001 From: Onurcankaratay Date: Fri, 15 Nov 2024 11:37:09 +0300 Subject: [PATCH 2/4] update disabled button styles --- src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss index e4f516ac95..e9c0f8dd20 100644 --- a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss +++ b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss @@ -25,6 +25,7 @@ transform: translate(0,-0.45px); } + &.disabled, &:disabled { cursor: default; pointer-events: auto; From 94bfc12569e2b80bfd036be0d62fd3b71edaa395 Mon Sep 17 00:00:00 2001 From: Onurcankaratay Date: Fri, 15 Nov 2024 12:41:54 +0300 Subject: [PATCH 3/4] bug fix --- .../static/scss/encoded/_bootstrap-theme-overrides.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss index e9c0f8dd20..ce430eb8b2 100644 --- a/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss +++ b/src/encoded/static/scss/encoded/_bootstrap-theme-overrides.scss @@ -29,6 +29,10 @@ &:disabled { cursor: default; pointer-events: auto; + + &:active { + pointer-events: none; + } } } From ad7606d8446128cc88bd37f5f89395d9e068340e Mon Sep 17 00:00:00 2001 From: Onurcankaratay Date: Fri, 15 Nov 2024 13:31:22 +0300 Subject: [PATCH 4/4] bump version + changelog --- CHANGELOG.rst | 12 ++++++++++++ pyproject.toml | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index c35d000831..8731399ac2 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -7,6 +7,18 @@ Change Log ---------- +8.4.4 +===== + +`Enable React Tooltip for Disabled Buttons `_ + +* Resolved an issue where **React Tooltip** was not displayed for `button` elements with the `disabled` attribute. +* Updated CSS for disabled buttons: + - `cursor` is now set to `default`. + - `pointer-events` is now set to `auto`. +* Tooltips are now consistently visible for disabled buttons. + + 8.4.3 ===== diff --git a/pyproject.toml b/pyproject.toml index ccc24538db..5b34cd575d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,7 +1,7 @@ [tool.poetry] # Note: Various modules refer to this system as "encoded", not "fourfront". name = "encoded" -version = "8.4.3" +version = "8.4.4" description = "4DN-DCIC Fourfront" authors = ["4DN-DCIC Team "] license = "MIT"