Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout fee estimation request #265

Closed
dpad85 opened this issue May 12, 2021 · 1 comment
Closed

Timeout fee estimation request #265

dpad85 opened this issue May 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@dpad85
Copy link
Member

dpad85 commented May 12, 2021

Getting the fees estimation is needed to properly reestablish channels. The wallet needs to offer a valid fee to its peer.

To do that we ask the electrum server for a fee estimation (see Peer.updateEstimateFee). However this request does not currently timeout. So if the electrum server we connect to is failing to respond, the node is stuck forever. It also does not respond to its LN peer, and eventually the connection is dropped by the peer.

We should instead timeout the request and disconnect from Electrum. We could then publish some kind of failure event so that the end client can display an error or connect to another electrum server.

We could also fallback to a known fee provider such as mempool.space, bitgo, ..., but that may not make a lot of sense, since we will eventually need to connect to a working electrum server anyway.

@dpad85 dpad85 added the bug Something isn't working label May 12, 2021
@dpad85 dpad85 added enhancement New feature or request and removed bug Something isn't working labels Oct 13, 2022
@t-bast
Copy link
Member

t-bast commented Sep 18, 2024

This changes drastically once we have #649, and I believe won't be an issue anymore. Closing for now and we'll re-open after #649 if something needs to be done.

@t-bast t-bast closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants