Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Aborted and Closed states #480

Open
t-bast opened this issue Jun 8, 2023 · 1 comment
Open

Rework Aborted and Closed states #480

t-bast opened this issue Jun 8, 2023 · 1 comment

Comments

@t-bast
Copy link
Member

t-bast commented Jun 8, 2023

It's a bit messy because we use Aborted in places where it should actually be Closed, but we can't because it requires an inner Closing.

An area to explore would be to remove Aborted and Closed entirely, and create a new action ChannelClosed that would:

  • if we had a persisted state, mark it as closed in the DB and remove from _channels
  • otherwise, just remove from _channels
@t-bast
Copy link
Member Author

t-bast commented Sep 26, 2023

We should also rework the trait hierarchy for channel states, so that Closing cannot be wrapped in Offline or Syncing (see #539).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant