Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS simulator target #74

Closed
TemMax opened this issue Mar 16, 2023 · 8 comments · Fixed by #92
Closed

iOS simulator target #74

TemMax opened this issue Mar 16, 2023 · 8 comments · Fixed by #92

Comments

@TemMax
Copy link

TemMax commented Mar 16, 2023

Hello.
Is it possible to build a library for the ios simulator (iosSimulatorArm64)? It could simplify testing many times.

@sstone
Copy link
Member

sstone commented Mar 20, 2023

I should be easy but I have not tried and only have a very limited experience with iOS.
You would first add the iosSimulatorArm64 {} target to the root build file (build.gradle.kts), modify secp256k1CInterop() to handle a new iosSimulatorArm65 target, and update build files in the native directory to handle the new target (build.gradle.kts and possibly xconfigure.sh).

@TemMax
Copy link
Author

TemMax commented Mar 20, 2023

Thanks a lot. I'll try it soon.

TemMax added a commit to TemMax/secp256k1-kmp that referenced this issue Apr 15, 2023
@TemMax
Copy link
Author

TemMax commented Apr 15, 2023

@sstone Hi! I've made a pull request with this feature. Could you review it, please?

The library was tested. It was published to the local repository and added to the KMM library, the KMM library was added to the iOS project and run on the device and simulator. The functionality works.

@TemMax
Copy link
Author

TemMax commented May 3, 2023

Ping-ping

@TemMax
Copy link
Author

TemMax commented Aug 14, 2023

I have made it in the fork and waiting until all targets are available from this repo.

@TemMax TemMax closed this as completed Aug 14, 2023
@kirillzh
Copy link

Sounds like this issue is still not resolved in this repository, could we keep the ticket open please?

@sstone
Copy link
Member

sstone commented Sep 20, 2023

Yes, OP closed this issue because they have their own solution but we don't yet, we will probably use what they implemented (thanks!) once our next iOS release is out.

@sstone sstone reopened this Sep 20, 2023
@colbyharrison
Copy link

Another vote for this getting done. We could use it too.

@sstone sstone linked a pull request Dec 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants