Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automatic testing strategy #921

Open
2 of 3 tasks
ns-rse opened this issue Oct 1, 2024 · 0 comments
Open
2 of 3 tasks

Improve automatic testing strategy #921

ns-rse opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
CI/CD tests Issues pertaining to testing

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 1, 2024

The use of GitFlow Workflow workflow to address the work that has been done on improving tracing and untangling molecules means that because the test suite we have in place to ensure changes do not break existing functionality and expected output do not run on pull requests to the target development branch (maxgamill-sheffield/800-better-tracing) since currently the workflow is setup to only run on pull requests that target the main branch...

.github/workflows/tests.yaml

name: Tests (pytest)

on:
  pull_request:
    branches:
      - main

This has led to problems as the changes introduced in this branch have broken a number of tests (see #850).

We should be catching these much earlier in the development cycle and there are a couple of approaches which I would like to consider.

I would also advocate against the overly complicated GitFlow Workflow which uses development branches and instead think we should use either GitHub or GitLab Flow instead. I would personally favour the former (GitHub Flow as attempts so far to define clear sets of features and establish Milestones under which release branches can be developed in the Gitlab Flow approach.

To date we have mostly used the GitHub Flow approach of merging all features to main and periodically tagging commits to trigger releases. This approach requires that tasks are broken down into smaller components which makes development and feedback considerably faster.

@ns-rse ns-rse added CI/CD tests Issues pertaining to testing labels Oct 1, 2024
@ns-rse ns-rse self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD tests Issues pertaining to testing
Projects
None yet
Development

No branches or pull requests

1 participant