Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approved labeler #557

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix approved labeler #557

merged 1 commit into from
Aug 7, 2023

Conversation

accorvin
Copy link
Member

@accorvin accorvin commented Aug 7, 2023

No description provided.

@accorvin
Copy link
Member Author

accorvin commented Aug 7, 2023

/approve

@accorvin accorvin merged commit 17b2bd6 into AICoE:main Aug 7, 2023
2 checks passed
@accorvin accorvin deleted the fix-approved-labeler branch August 7, 2023 15:48
@goern
Copy link
Member

goern commented Aug 7, 2023

This label will not do anything else than being an information, no bot will merge, right?!

@goern
Copy link
Member

goern commented Aug 7, 2023

ah, #555 is related ;)

@accorvin
Copy link
Member Author

accorvin commented Aug 7, 2023

@goern this is still a work in progress, but yeah what I'm working towards is the automerge action automatically merging an approved PR. I may end up scrapping it though and just using the built in github PR auto merge functionality where you can set a pull reqeust to merge once all required checks have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants