Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically create kernels for tutorial using jupyterlab-requirements-cli in a step in aicoe-pipeline #35

Open
pacospace opened this issue Jul 6, 2021 · 10 comments
Labels
area/comet Issues or PRs related to Team Comet area/shooting-star Issues or PRs related to Team Shooting Star priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@pacospace
Copy link

pacospace commented Jul 6, 2021

This could be done after image is spawned (checking dependencies from the notebooks) and install those kernels so they are ready for the users. Even though it will slow down a bit the spawning process

@pacospace
Copy link
Author

Related-To: thoth-station/jupyterlab-requirements#324

@pacospace
Copy link
Author

pacospace commented Jul 8, 2021

cc @MichaelClifford, so we can skip some steps of the tutorial, wdyt?

@tumido
Copy link
Member

tumido commented Jul 12, 2021

I'm confused @pacospace if this should be done after the image is spawned, it can't be part of the build pipeline. Can you please clarify when you expect this step to happen?

If it's part of the build phase, can this be included as a custom s2i assembly script? It seems fairly specific for this given use case/repository, isn't it?

@tumido
Copy link
Member

tumido commented Jul 12, 2021

/area comet
/area shooting-star

@sesheta sesheta added area/comet Issues or PRs related to Team Comet area/shooting-star Issues or PRs related to Team Shooting Star labels Jul 12, 2021
@pacospace
Copy link
Author

I'm confused @pacospace if this should be done after the image is spawned, it can't be part of the build pipeline. Can you please clarify when you expect this step to happen?

If it's part of the build phase, can this be included as a custom s2i assembly script? It seems fairly specific for this given use case/repository, isn't it?

Yes build process sounds good, s2i assembly script seems to be the right place.

In this way, if notebooks are missing dependencies, the build process will fail also as those are not reproducible.

@pacospace
Copy link
Author

@sesheta
Copy link

sesheta commented Oct 17, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2021
@sesheta
Copy link

sesheta commented Nov 16, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 16, 2021
@sesheta
Copy link

sesheta commented Dec 16, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Dec 16, 2021
@sesheta
Copy link

sesheta commented Dec 16, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Dec 16, 2021
@pacospace pacospace added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 16, 2021
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/comet Issues or PRs related to Team Comet area/shooting-star Issues or PRs related to Team Shooting Star priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants