Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ovmf fail, No rule to make target '../Include/X64/ProcessorBind.h' #7

Open
lcmfq opened this issue Jun 25, 2024 · 2 comments
Open

Comments

@lcmfq
Copy link

lcmfq commented Jun 25, 2024

[root@anolis ovmf-snp-latest]# make -C BaseTools
make: Entering directory '/home/kos/kernel/ovmf-snp-latest/BaseTools'
make -C Source/C
make[1]: Entering directory '/home/kos/kernel/ovmf-snp-latest/BaseTools/Source/C'
Attempting to detect HOST_ARCH from 'uname -m': x86_64
Detected HOST_ARCH of X64 using uname.
mkdir -p .
make -C Common
make[2]: Entering directory '/home/kos/kernel/ovmf-snp-latest/BaseTools/Source/C/Common'
make[2]: *** No rule to make target '../Include/X64/ProcessorBind.h', needed by 'BasePeCoff.o'. Stop.
make[2]: Leaving directory '/home/kos/kernel/ovmf-snp-latest/BaseTools/Source/C/Common'
make[1]: *** [GNUmakefile:79: Common] Error 2
make[1]: Leaving directory '/home/kos/kernel/ovmf-snp-latest/BaseTools/Source/C'
make: *** [GNUmakefile:19: Source/C] Error 2
make: Leaving directory '/home/kos/kernel/ovmf-snp-latest/BaseTools'

@tlendacky
Copy link
Collaborator

tlendacky commented Jun 25, 2024

Try doing "make -C BaseTools clean" and then "make -C BaseTools".

@lcmfq
Copy link
Author

lcmfq commented Jun 26, 2024

Thank you, it has been resolved

dimstav23 pushed a commit to dimstav23/amd-ovmf that referenced this issue Oct 2, 2024
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4540

Bug Details:
PixieFail Bug AMDESE#7
CVE-2023-45235
CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H
CWE-119 Improper Restriction of Operations within the Bounds of
 a Memory Buffer

Buffer overflow when handling Server ID option from a DHCPv6 proxy
Advertise message

Change Overview:

Performs two checks

1. Checks that the length of the duid is accurate
> + //
> + // Check that the minimum and maximum requirements are met
> + //
> + if ((OpLen < PXEBC_MIN_SIZE_OF_DUID) ||
(OpLen > PXEBC_MAX_SIZE_OF_DUID)) {
> +  Status = EFI_INVALID_PARAMETER;
> +  goto ON_ERROR;
> + }

2. Ensures that the amount of data written to the buffer is tracked and
never exceeds that
> + //
> + // Check that the option length is valid.
> + //
> + if ((DiscoverLen + OpLen + PXEBC_COMBINED_SIZE_OF_OPT_CODE_AND_LEN)
 > DiscoverLenNeeded) {
> +     Status = EFI_OUT_OF_RESOURCES;
> +     goto ON_ERROR;
> + }

Additional code clean up and fix for memory leak in case Option was NULL

Cc: Saloni Kasbekar <[email protected]>
Cc: Zachary Clark-williams <[email protected]>

Signed-off-by: Doug Flick [MSFT] <[email protected]>
Reviewed-by: Saloni Kasbekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants