Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

sbrk: Superfluous public function mbed_krbs_ex #78

Open
LiyouZhou opened this issue Feb 22, 2016 · 2 comments
Open

sbrk: Superfluous public function mbed_krbs_ex #78

LiyouZhou opened this issue Feb 22, 2016 · 2 comments
Labels

Comments

@LiyouZhou
Copy link

https://github.com/ARMmbed/core-util/blob/master/source/sbrk.cpp#L59

void * mbed_krbs_ex(const ptrdiff_t size, ptrdiff_t *actual)

Is used in:

void * mbed_krbs(const ptrdiff_t size)
{
    return mbed_krbs_ex(size, NULL);
}

Few issues:

  1. It is unclear why is mbed_krbs_ex public, and what is the purpose of the actual parameter.
  2. https://github.com/ARMmbed/core-util/blob/master/source/sbrk.cpp#L82 this line does not seem to do anything.

@bogdanm Can you comment on this?

@LiyouZhou LiyouZhou changed the title Superfluous public function mbed_krbs_ex sbrk: Superfluous public function mbed_krbs_ex Feb 22, 2016
@LiyouZhou
Copy link
Author

@0xc0170 for watching this issue.

@ciarmcom
Copy link
Member

ARM Internal Ref: IOTSFW-2099

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants