Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.ico doesn't render correctly #2278

Open
asjohnston-asf opened this issue May 13, 2024 · 2 comments
Open

favicon.ico doesn't render correctly #2278

asjohnston-asf opened this issue May 13, 2024 · 2 comments

Comments

@asjohnston-asf
Copy link
Member

asjohnston-asf commented May 13, 2024

The OpenAPI logo included as a favicon for the swagger UI doesn't render correctly for https://hyp3-api.asf.alaska.edu/ui/

image

Requests to the underlying resources return content, but the content is incorrectly encoded:

@asjohnston-asf
Copy link
Member Author

See https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-payload-encodings.html for more discussion of serving binary content from an API Gateway REST API.

serverless_wsgi already handles the text-vs-binary encoding of the response body for us, so updating binaryMediaTypes in the API Gateway configuration should be sufficient.

@jtherrmann
Copy link
Contributor

Adding:

      BinaryMediaTypes:
        - '*/*'

Under RestApi:Properties: in apps/api/api-cf.yml.j2 fixes the issue for non-EDC deployments. We haven't determined why this solution doesn't work for our EDC deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants