Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final preprocessing #31

Open
Fedorov113 opened this issue Mar 29, 2020 · 0 comments
Open

final preprocessing #31

Fedorov113 opened this issue Mar 29, 2020 · 0 comments

Comments

@Fedorov113
Copy link
Collaborator

Fedorov113 commented Mar 29, 2020

How should we organize this?
First of all we should have --final in any result that is preprocessing. But what default should it have? Also preprocessing Results should expose what term they add to preproc. For Trimmomatic it would be tmtic_params.

TRUE
If the user requests just one preprocessing in command - everyrhing is fine, we just mark that this preprocessing is final for this samples, and the user can continue. But if the user wants to request multiple preprocessings? They all will be set as final in order of appearance in request, so the last one requested will end up being final.

Another issue is what to if the user requests preprocessing that is doable but not created? Say, have just raw samples at the moment and user requestsmetaphlan2 -d <DATASET> -p raw__tmtic_def. We should first check that it is doable, and then add new result to global requested results. Marking resulting files as final seems pretty logical.

Chaining preprocs and sample sets in general? assnake result trimmomatic -d DF rm-human

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant