Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

[PE-D] Incorrect error message on add #184

Closed
nus-se-script opened this issue Apr 1, 2022 · 3 comments
Closed

[PE-D] Incorrect error message on add #184

nus-se-script opened this issue Apr 1, 2022 · 3 comments
Assignees
Milestone

Comments

@nus-se-script
Copy link

When the add command is run with all the compulsory fields and the idt field, the error message that is thrown corresponds to the last field instead of telling the user that the idt field is invalid.

Eg: find j/engineer p/1244 a/aa e/[email protected] n/name idt/02-02-2022 04:30 produces the error message
"Names should only contain alphanumeric characters and spaces, and it should not be blank"

Screenshot 2022-04-01 at 5.44.26 PM.png


Labels: severity.Low type.FeatureFlaw
original: manu2002g/ped#8

@lchokhoe
Copy link
Collaborator

lchokhoe commented Apr 2, 2022

Reason for behaviour: "idt/" is not a recognised prefix for the "add" command. Hence, "name idt/02-02-2022 04:30" is being parsed as a single "n/" input which is triggering the error message.

I believe this is an intended behaviour

@laughingkid-sg laughingkid-sg self-assigned this Apr 3, 2022
@joszx
Copy link
Collaborator

joszx commented Apr 3, 2022

Maybe we can flesh out the UG and mention this intended behavior in FAQ

@laughingkid-sg laughingkid-sg added this to the v1.4 milestone Apr 3, 2022
@laughingkid-sg
Copy link
Collaborator

The command /idt does not work with add command.

Reason: Interview dates are not given when you apply for an internship.

Will update this in FAQ.

@laughingkid-sg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants