-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MrCrayfish Furniture Mod + srm cause crash #272
Comments
I'll need to see the crash logs to be able to do anything |
I may be able to find it, I'm currently posting this from my laptop, and not my desktop, so this may take a while. |
|
I'm nowhere near even an amateur level at coding (I build pcs) but I think from what I experienced that it's a graphical problem |
The issue is sorta srm sorta Mr crayfish. Srm does some janky stuff to work, including delegating other blocks. The issue with this is that the tile entity in world at that blocks position will never be what the block expects it to be. At here, Mr crayfish expects the tileentity to be his own, without checking it, causing a crash. There's not really much I can do, secret rooms does a lot of hacky stuff to work, and even after a year since I last opened the code base, I wouldn't really know how else to do it. I do hope that a 1.13 rewrite would mean it's not as broken as it is right now, as there are some things I would do differently, but not the thing causing this |
I'll see if MrCrayfish can make anything of this, this was a large issue for me, and if my friend wouldn't have gotten rid of it we would have had to reset player files 😒 but thanks for letting me know what's up. |
I can make it so it won't crash the world, but not much I can do so it would work normally |
I'm over at the Furniture mod repo reporting this right now. |
Optifine?: No
A few days ago me and my friend were playing on my personal server running 1.12.2 (srm 5.6.4) and found a bit of an extremely large problem. We have the MrCrayfish Furniture Mod installed, which comes with couches that change their model as more are placed. For whatever reason I thought it would be a great idea to place one way glass on it to see what it did, and my game crashed immediately. When I restarted my client and logged in, I got kicked back out by an "Internal Server Error."
My friend then ventured in there to attempt to destroy it, and to no avail, because as soon as he saw it, it ALSO crashed his game, and then we were both unable to do anything at all. After I set the server back a couple hundred ticks, he managed to spawn in front of it, where he couldn't see it, and managed to use TNT to remove it, fixing the problem and allowing us to log in. I don't understand entirely why this would happen but wanted to let other people know so they don't make the same mistake.
The text was updated successfully, but these errors were encountered: