Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor SlackBot code into a Slack demo #369

Open
oshoma opened this issue May 8, 2024 · 0 comments
Open

[FEATURE] Refactor SlackBot code into a Slack demo #369

oshoma opened this issue May 8, 2024 · 0 comments
Labels
help wanted Extra attention is needed Improvement

Comments

@oshoma
Copy link
Collaborator

oshoma commented May 8, 2024

PROBLEM
The core Sherpa functionality is packaged as a Python library which other apps can include.
In contrast, the Slack Bot functionality in /src/apps/slackapp is really more of a demo of
Sherpa's capabilities now, and it is not part of the Sherpa package we publish to PyPi. It would be nice to keep Slack functionality, but it should not live in the /src directory any longer.

SOLUTION

  • Move the Slack functionality from /src/apps/slackapp to /demo/slackbot
  • Update the tests and makefile as needed to ensure it still works
  • Edit /docs to clarify that the Slack feature is a demo, not part of the Sherpa library
    • About Sherpa/index.rst
    • How To/Slack Bot
  • Update the README as needed
@oshoma oshoma added help wanted Extra attention is needed Improvement labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Improvement
Projects
None yet
Development

No branches or pull requests

1 participant