Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature Request] Add setting for base href #131

Open
OdinVex opened this issue Mar 8, 2024 · 6 comments
Open

[Bug/Feature Request] Add setting for base href #131

OdinVex opened this issue Mar 8, 2024 · 6 comments

Comments

@OdinVex
Copy link

OdinVex commented Mar 8, 2024

If you could add the ability to specify a base href (such as through ENV vars with Docker) that'd allow me to host under a subpath rather than trying to muck with ports. You could use OPEN_SEARCH_HOST (if set).

@Ahwxorg
Copy link
Owner

Ahwxorg commented Mar 8, 2024

What is wrong with our current implementation for subdomains? Why not use that? Most of the people that host LibreY host it under a subdomain.

@OdinVex
Copy link
Author

OdinVex commented Mar 8, 2024

Because I don't want to use a subdomain. I'll just maintain a patch (edit: for myself and others who want the same). Fortunately Docker's entrypoint command can be co-opted to run a shell script and then call the normal entrypoint. Useful for patching when upstream is rigid.

@Ahwxorg
Copy link
Owner

Ahwxorg commented Mar 8, 2024

Then what is your goal?

@OdinVex
Copy link
Author

OdinVex commented Mar 8, 2024

My goal was to suggest a rather simple feature. No one's said yes or no, so I left this open for someone else to possibly do that.

@davidovski
Copy link

I think that this is an interesting idea, though I'm not sure its something that needs to be implemented LibreY directly, probably better suited configured via the webserver (ie nginx/caddy).

Perhaps there is a way to fix LibreY page to find files relative to themselves, rather than relying on any particular root. (ie not having includes, hrefs and img src's start with /) Using a config option for this would probably just be a bandaid fix, as i see no reason as to why LibreY shouldn't just work on any subpath.

@OdinVex
Copy link
Author

OdinVex commented Mar 8, 2024

Using relative links would adjust the issue, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants