Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerized downloader_app (WIP) #55

Closed
wants to merge 1 commit into from
Closed

Containerized downloader_app (WIP) #55

wants to merge 1 commit into from

Conversation

esloch
Copy link
Collaborator

@esloch esloch commented Aug 18, 2020

@esloch esloch requested review from fccoelho and xmnlab August 18, 2020 01:39
fccoelho
fccoelho approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@fccoelho fccoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria legal adicional adicionar testes para a função download_tiffs. Não sei se ficaria muito pesado.
De resto parece ok.

@esloch
Copy link
Collaborator Author

esloch commented Aug 18, 2020

Seria legal adicional adicionar testes para a função download_tiffs. Não sei se ficaria muito pesado.
De resto parece ok.

Ok. Thanks!

@esloch esloch changed the title Containerized downloader_app Containerized downloader_app (WIP) Aug 18, 2020
fccoelho
fccoelho approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@fccoelho fccoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@esloch esloch mentioned this pull request Sep 4, 2020
Merged
@esloch
Copy link
Collaborator Author

esloch commented Sep 4, 2020

  • Continue in PR#57.
    Reason:
Secrets are not passed to workflows that are triggered by a pull request from a fork.

@esloch esloch closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fccoelho fccoelho fccoelho approved these changes

@xmnlab xmnlab Awaiting requested review from xmnlab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Continuous capture of Satellite images
2 participants
@esloch @fccoelho