Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luck adjustments phase 2+ #100

Open
7 of 12 tasks
Alex-At-Home opened this issue Jun 28, 2020 · 1 comment
Open
7 of 12 tasks

Luck adjustments phase 2+ #100

Alex-At-Home opened this issue Jun 28, 2020 · 1 comment
Labels
meta For lists of issues

Comments

@Alex-At-Home
Copy link
Owner

Alex-At-Home commented Jun 28, 2020 •
edited
Loading

  • Have a generic advanced options dialog [#100] Luck adjustment config #103
  • Apply to lineups [#100][#102] Incorporate luck adjustments into lineup view #104
  • Apply to team report Luck adjusted RAPM (etc) #113 (partially pulled out for RAPM in [#162] Fix RAPM/luck inconsistencies #174)
  • Add option for mid-range 2s
  • Regress 3P normally if missing 3P Sos (ie for women)
  • Apply to individuals [#100][#59] Individual luck #110
  • Docs ff310da
  • Apply luck correctly to lineups (requires including 3P shooter info in the lineup stats)
  • off 3P luck at least not correctly applied to totals (bug) - d94b0ad
  • Currently don't re-apply luck to "lineup totals", just aggregate existing entries - both are wrong, but with both done correctly - which is more wrong?! I think once lineups have more info, aggregating luck is def right?
    • (basically I override the sample size for each lineup to pretend it's bigger, which means I'm under-regressing each lineup's 3P shooting but the total is correctly regressed - aside from not knowing which players took the shots)
      • (arguably nicer would be correctly regressing the lineups but then ignoring that for the total lineups .. though that would have the effect of giving each lineup's 3P shooting the team value, which is not fun)
    • Could maybe make it an option controlled from the luck config lineup?
  • Use assisted% to strengthen/loosen regression (eg allow higher 3P% if assisted% is also higher)
@Alex-At-Home Alex-At-Home added the meta For lists of issues label Jun 28, 2020
Alex-At-Home added a commit that referenced this issue Jul 9, 2020
@Alex-At-Home
Merge pull request #103 from Alex-At-Home/luck_adjustment_config
26db693 
[#100] Luck adjustment config
Alex-At-Home added a commit that referenced this issue Jul 10, 2020
@Alex-At-Home
Merge pull request #104 from Alex-At-Home/lineup_luck
ff310da 
[#100][#102] Incorporate luck adjustments into lineup view
Alex-At-Home pushed a commit that referenced this issue Jul 17, 2020
[#100] Add docs for luck (and other menu items at the same time)
972eba8
Alex-At-Home added a commit that referenced this issue Jul 24, 2020
@Alex-At-Home
Merge pull request #110 from Alex-At-Home/indiv_luck
355122c 
[#100][#59] Individual luck
@Alex-At-Home
Copy link
Owner Author

Currently applying luck to lineups adds a ton of noise because I've no idea which players have taken which shots...

@Alex-At-Home Alex-At-Home added bug Something isn't working and removed bug Something isn't working labels Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta For lists of issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alex-At-Home