Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: individual analysis possession counts aren't quite correct #76

Open
Alex-At-Home opened this issue Apr 26, 2020 · 0 comments
Open

Minor: individual analysis possession counts aren't quite correct #76

Alex-At-Home opened this issue Apr 26, 2020 · 0 comments
Labels
wontfix This will not be worked on

Comments

@Alex-At-Home
Copy link
Owner

If there are errored lineups that didn't count as errored player_events, then the possession % isn't quite right (it can exceed 100%, for now I've just capped that)

Should perform a sum of possessions at the top level of on/off/baseline over player_counts and use that for consistency

Note I made a real mess of this, that's what:

are all about
@Alex-At-Home Alex-At-Home added the wontfix This will not be worked on label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alex-At-Home