Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate use of "_.clone" #97

Open
Alex-At-Home opened this issue Jun 12, 2020 · 1 comment
Open

Investigate use of "_.clone" #97

Alex-At-Home opened this issue Jun 12, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Alex-At-Home
Copy link
Owner

I noticed in ncaaToKenpomLookup.ts that

_.merge(_.clone(ncaaToKenpomLookup_2016_17), {

Was still mutating ncaaToKenpomLookup_2016_17, and I needed _.cloneDeep ... I have used _.clone elsewhere, check those out and see if it's working as expected
@Alex-At-Home Alex-At-Home added the bug Something isn't working label Jun 12, 2020
@Alex-At-Home
Copy link
Owner Author

  • components/diags/RapmGlobalDiagView.tsx
  • utils/QueryUtils.ts
  • utils/stats/LineupUtils.ts
  • utils/stats/PositionsUtils.ts
  • utils/stats/RapmUtils.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alex-At-Home