Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit config #159

Closed
neubig opened this issue Oct 8, 2024 · 2 comments · Fixed by #160
Closed

Add pre-commit config #159

neubig opened this issue Oct 8, 2024 · 2 comments · Fixed by #160
Labels
fix-me Try to automatically fix the issue with OpenHands

Comments

@neubig
Copy link
Contributor

neubig commented Oct 8, 2024

We should add a pre-commit config that does linting with ruff and type checking with mypy.
@neubig neubig added the fix-me Try to automatically fix the issue with OpenHands label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

OpenHands started fixing the issue! You can monitor the progress here.

openhands-agent added a commit that referenced this issue Oct 8, 2024
@openhands-agent
Fix issue #159: 'Add pre-commit config'
c70b992
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

A potential fix has been generated and a draft PR #160 has been created. Please review the changes.

@openhands-agent openhands-agent mentioned this issue Oct 8, 2024
Merged
neubig added a commit that referenced this issue Oct 8, 2024
@openhands-agent @neubig
Fix issue #159: Add pre-commit config (#160)
8955dcb 
* Fix issue #159: 'Add pre-commit config'

* Apply suggestions from code review

* Update lock

* Add pre-commit action

---------

Co-authored-by: Graham Neubig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-me Try to automatically fix the issue with OpenHands
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #159: Add pre-commit config All-Hands-AI/openhands-resolver
1 participant
@neubig