Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, skip fixing issues that already have a pull request open #63

Open
neubig opened this issue Sep 23, 2024 · 0 comments
Open

Comments

@neubig
Copy link
Contributor

neubig commented Sep 23, 2024

If an issue already has a pull request open, it would be better to not try to solve it again by default. We should modify github_resolver/resolve_issues.py to fix this:

  1. Change the type of "success" in the resolver result class from boolean to an enum with true, false, and skipped
  2. Write code that skips all issues that have a pull request open by default
  3. Add a new option that makes it possible to override this default and also create PRs when a pull request is open

Tests should be written to test all three pieces of this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant