Bugfix: make Scene Management widget closable (settings persist) #67
Conversation
Codecov ReportBase: 87.68% // Head: 87.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 87.68% 87.29% -0.40%
==========================================
Files 4 3 -1
Lines 203 181 -22
==========================================
- Hits 178 158 -20
+ Misses 25 23 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
To clarify. This PR should go in after the other merges correct? They are sort of tied together? Or is this a bug that currently exists? |
|
This is just a fix for the bug/issue with the two-widget solution to multiscene files. It has nothing to do with the new settings widget. I guess I can see how it can be confusing... Edit: note: I'm not sure this is the best or most pythonic fix. It's just a fix 😃 |
This PR aims to fix #66
When a multi-scene file is loaded, two widgets are created.
One has two checkboxes, the other has the scenes to load.
The status of the first widget (the checkboxes) is checked when the scenes are to be loaded. As a result, if that widget is closed an error is raised.
In this PR, the first widget instead sets global variables, so it need not be open.
If the settings are applied, then the widget can be closed and scenes can be loaded.
(this permits more vertical space for scene selection, particularly on smaller screens—like mine!)
Additionally, the previous values are persisted thanks to magicgui.