Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on the paper #18

Open
YehorYudinIPP opened this issue Jul 12, 2024 · 0 comments
Open

Comments on the paper #18

YehorYudinIPP opened this issue Jul 12, 2024 · 0 comments

Comments

@YehorYudinIPP
Copy link

Dear Andrew,

I have read your JOSS paper and have several comments and suggestions on it, mainly regarding the citing.

Firstly, it would be appreciated if the paper had DOI or other indicators for the cited papers.

Secondly, the paper would benefit from citing the Golub-Welsch algorithm implementation by Laurie and Gautschi, providing a more explicit description of this algorithm, as well as commenting on the Dijkstra algorithm.

Thirdly, it would be nice if the paper explicitly included the expressions of the solved integrals and necessary parameters like the integral domain and function calls to compute the integrals. This includes a concealed expression cited as the equation (32) for |𝐴32(𝑥1, 𝑥2)| from Hewett et al. (2019).

All the best,
Yehor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant