Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table declarations with no columns should not be usable in queries #305

Open
AnyhowStep opened this issue Apr 5, 2020 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@AnyhowStep
Copy link
Owner

For example,

const myTable = sql.table("myTable");

pool.acquire(async (connection) => {
    //Place all database calls inside here
    const row = await sql.from(myTable)
        .select(columns => [columns])
        .fetchAll(connection);
    console.log(row);
});

Playground

Expected: Compile error

Actual: Compiles, run-time error


This isn't a super-critical bug, in my opinion. But it would be nice to fix this.

Most people should not run into this problem.

@AnyhowStep AnyhowStep added the bug Something isn't working label Apr 5, 2020
@AnyhowStep AnyhowStep self-assigned this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant