Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add manifest.json to source tree? #69

Open
mikeshultz opened this issue Oct 31, 2023 · 1 comment
Open

chore: add manifest.json to source tree? #69

mikeshultz opened this issue Oct 31, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@mikeshultz
Copy link
Member

I'm not entirely versed in the reasons why this file is handled the way it is, but I'm wondering if it would be beneficial to just add it to the python sdk source tree. The file is unlikely to change unless we alter the contract which seems unlikely without a version split, at least.

This also makes using a repo def cleaner. For instance:

apepay = { git = "https://github.com/ApeWorX/ApePay.git" }

Doesn't exactly work.

Maybe there's an alternative to having the project build include the compilation and copy but that seems extreme. Thoughts?

@mikeshultz mikeshultz added enhancement New feature or request question Further information is requested labels Oct 31, 2023
@fubuloubu
Copy link
Member

still haven't really figured out a good way to bundle the manifest with a python package so that SDKs work out of the box without needing to compile things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants