Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize existing HDPath class spec #6

Open
antazoey opened this issue Sep 25, 2021 · 0 comments
Open

Utilize existing HDPath class spec #6

antazoey opened this issue Sep 25, 2021 · 0 comments
Labels
category: feature New feature or request

Comments

@antazoey
Copy link
Member

Overview

Try to use checkout https://github.com/ethereum/eth-account/blob/bd3dc2c0e85934b9c47980053d9f1d16a7540990/eth_account/hdaccount/deterministic.py#L187
for HDPath instead of using our own implementation.

Keep in mind that ours is a bit ledger-specific, so we may need to subclass or something.

Specification

Rely on checkout https://github.com/ethereum/eth-account/blob/bd3dc2c0e85934b9c47980053d9f1d16a7540990/eth_account/hdaccount/deterministic.py#L187 for path validation (and class definition).

Just try (maybe a spike?)

Dependencies

Include links to any open issues that must be resolved before this feature can be implemented.

@antazoey antazoey added the category: feature New feature or request label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant