Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate v8 build with .NET 8 #1141

Closed
Tracked by #1302
martincostello opened this issue Apr 18, 2023 · 8 comments
Closed
Tracked by #1302

Validate v8 build with .NET 8 #1141

martincostello opened this issue Apr 18, 2023 · 8 comments
Assignees
Labels
CI/build v8 Issues related to the new version 8 of the Polly library.
Milestone

Comments

@martincostello
Copy link
Member

Add a build configuration to validate in CI that Polly v8 works as expected with .NET 8 with a net8.0 TFM using the prerelease packages.

Once preview 4 is available, remove the internal TimeProvider copy and use the version shipping in a NuGet package instead.

Once .NET 8 ships as stable in November, we can then roll net8.0 into the main build setup and ship a package that explicitly supports it.

@martincostello martincostello added this to the v8.0.0 milestone Apr 18, 2023
@martincostello martincostello self-assigned this Apr 18, 2023
@martincostello martincostello added CI/build v8 Issues related to the new version 8 of the Polly library. labels Apr 18, 2023
@martintmk
Copy link
Contributor

As a part of this task we should also unify all Microsoft.Extensions.* and System.* packages to version 8.0.0. These versions should fix known compatibility problems seen in versions. Would simplify our setup too as we don't have to deal with different versions for each framework anymore.

@martincostello
Copy link
Member Author

Yep I'll sort that out once it's available (that's p4 too right?). For now I've just extended the multi-targeting while I'm playing with it locally.

@martintmk
Copy link
Contributor

that's p4 too right?

Hopefully yes, we just need to wait until the System.Bcl.TimeProvider package appears in nuget :)

martincostello added a commit that referenced this issue Apr 18, 2023
- Update to .NET 8 SDK.
- Add `net8.0` TFM.
- Bump packages to .NET 8 versions where relevant.
- Remove `Microsoft.CodeAnalysis.NetAnalyzers`.

Relates to #1141.
@martintmk
Copy link
Contributor

@martincostello I came across this post:

https://devblogs.microsoft.com/dotnet/package-validation/

I think it's something we can do for V8 too! ;)

@martincostello
Copy link
Member Author

Yep it would be good to add that too - I already use it in a number of my OSS projects. We should be able to enable it separate from the .NET 8 upgrade.

martincostello added a commit to martincostello/Polly that referenced this issue May 2, 2023
Add NuGet package validation analysers.
See App-vNext#1141 (comment).
@martincostello
Copy link
Member Author

Added package validation in #1172. There's also some additional checking already as part of #1134.

martincostello added a commit that referenced this issue May 2, 2023
Add NuGet package validation analysers.
See #1141 (comment).
martincostello added a commit that referenced this issue May 17, 2023
- Update to .NET 8 SDK.
- Add `net8.0` TFM.
- Bump packages to .NET 8 versions where relevant.
- Remove `Microsoft.CodeAnalysis.NetAnalyzers`.

Relates to #1141.
martincostello added a commit that referenced this issue May 17, 2023
- Update to .NET 8 SDK.
- Add `net8.0` TFM.
- Bump packages to .NET 8 versions where relevant.
- Remove `Microsoft.CodeAnalysis.NetAnalyzers`.

Relates to #1141.
martincostello added a commit that referenced this issue May 18, 2023
- Update to .NET 8 SDK.
- Add `net8.0` TFM.
- Bump packages to .NET 8 versions where relevant.
- Remove `Microsoft.CodeAnalysis.NetAnalyzers`.

Relates to #1141.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

@github-actions github-actions bot added the stale Stale issues or pull requests label Jul 2, 2023
@martincostello martincostello removed the stale Stale issues or pull requests label Jul 2, 2023
@martincostello martincostello modified the milestones: v8.0.0, v8.1.0 Sep 27, 2023
@martincostello martincostello modified the milestones: v8.1.0, v8.2.0 Oct 30, 2023
@martincostello
Copy link
Member Author

Completed by #1144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/build v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants