Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stylelint #521

Open
kamilzyla opened this issue Jan 5, 2024 · 0 comments
Open

Upgrade stylelint #521

kamilzyla opened this issue Jan 5, 2024 · 0 comments

Comments

@kamilzyla
Copy link
Collaborator

Problem

Currently rhino::lint_sass() uses stylelint v14 which is the last major version of supporting stylistic rules. With v15 stylelintdecided to delegate all formatting to pretty printers (e.g. prettier). It no longer cares about code formatting (whitespace, line breaks, etc.).

We don't want to stay with stylelint v14 forever, but plain upgrade to the latest version would remove a large portion rhino::lint_sass() functionality.

Solutions

After upgrading stylelint to latest version we'll need to make up for the lost functionality. Two approaches come to mind:

  1. Use @stylistic/stylelint-plugin, which should essentially bring back the functionality.
  2. Introduce a pretty printer (e.g. prettier) and integrate it into Rhino. Our API might need adjustment, e.g. rhino::format_sass() instead of rhino::lint_sass(fix = TRUE).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant