Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.google.gwt : 2.8.0 -> 2.9.0 #832

Open
robinroos opened this issue May 17, 2020 · 6 comments
Open

Upgrade com.google.gwt : 2.8.0 -> 2.9.0 #832

robinroos opened this issue May 17, 2020 · 6 comments

Comments

@robinroos
Copy link

Upgrade com.google.gwt : 2.8.0 -> 2.9.0 and uplift other dependency versions as necessary to be in synch with transitive dependency versions resolved through gwt:2.9.0.

@robinroos
Copy link
Author

Just a quick note. Having forked the repo, and created the feature branch, using Maven 3.6.3 "mvn clean install" succeeds but issues five warnings:

[WARNING] JAR will be empty - no content was marked for inclusion!
[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'com.gwtplatform:*:*:sources'
[WARNING] Artifact: com.gwtplatform:gwtp-all:jar:2.0-SNAPSHOT references the same file as the assembly destination file. Moving it to a temporary location for inclusion.
[WARNING] Configuration options: 'appendAssemblyId' is set to false, and 'classifier' is missing.
Instead of attaching the assembly file: /Users/robin/IdeaProjects/GWTP/gwtp-core/gwtp-all/target/gwtp-all-2.0-SNAPSHOT.jar, it will become the file for main project artifact.
NOTE: If multiple descriptors or descriptor-formats are provided for this project, the value of this file will be non-deterministic!
[WARNING] Replacing pre-existing project main-artifact file: /Users/robin/IdeaProjects/GWTP/gwtp-core/gwtp-all/target/archive-tmp/gwtp-all-2.0-SNAPSHOT.jar
with assembly file: /Users/robin/IdeaProjects/GWTP/gwtp-core/gwtp-all/target/gwtp-all-2.0-SNAPSHOT.jar

@robinroos
Copy link
Author

robinroos commented May 18, 2020

Having locally upgraded GWTP to use gwt-2.9.0, dependency convergence issues manifest which require some action on the part of GWT itself. I have raised these on gitter (gwtproject/gwt) and will shortly create an issue in the GWT issue tracker and link back to here.

Hi Folks. I'm looking into dependency convergence across GWT Material Design which depends on GWTP which depends on GWT (targeting 2.9.0).
Convergence would require GWT to accommodate the following changes:
htmlunit :compile -> :test
asm 7.1 -> 7.2
jukito:1.4.1 -> 1.5
The change of scope for htmlunit would be the most helpful. The version bump for jukito is the lest necessary since it is a :test dependency anyway.
I had a brief look at the GWT master, but the project structure makes it impracticable for me to submit a PR for the changes.
Could you point me to the correct issue tracker to raise this Convergence request? I hope that this could be accommodated in the next point release (2.9.1).

@rszwajko
Copy link

rszwajko commented Aug 4, 2020

Having locally upgraded GWTP to use gwt-2.9.0, dependency convergence issues manifest

@robinroos
What kind of convergence issues have you encountered?

@sblommers
Copy link

sblommers commented Jun 24, 2021

@robinroos can you please explain in a few words what issues you encountered? It's a but difficult to find your concerns on gitter because they are very chatty there :-)
Does this mean we need a 2.9.1 release of GWT first to be able to move up?

@robinroos
Copy link
Author

Hi Folks,

I probably saw issues only when Macbeth was building, and those were probably warnings and not real issues.

I've moved back onto server-side projects since then and am no longer close to this.

I suggest it would be fine to close the issue I raised.

Kind regards, Robin.

@robinroos
Copy link
Author

Macbeth = Maven (!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants