Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-side filtering docs #226

Open
komasoftware opened this issue May 25, 2015 · 0 comments
Open

server-side filtering docs #226

komasoftware opened this issue May 25, 2015 · 0 comments
Assignees

Comments

@komasoftware
Copy link

In the documentation for server side filtering, this line of code does not make sense to me (and removing it makes the code work) :

 if (isShowing && initialized) {
            return; // do nothing, keep the last results
}
initialized = true;

This will only display the initial query and won't react to typing (as does the demo !)

In my implementation, I simply have :

if (!isShowing) {
 return;
}

so we won't hit the server unnecessary.

@christiangoudreau christiangoudreau added this to the 2.2.0 milestone May 26, 2015
@olafleur olafleur removed this from the 2.2.0 milestone Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants