Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider outputting two TSV files instead of one from combine_peptide_annotations.R #16

Closed
taylorreiter opened this issue Feb 26, 2024 · 1 comment

Comments

@taylorreiter
Copy link
Member

As currently written, the left join with peptide_predictions will duplicate all of the information in all of the left-joined dataframes for any peptides that appear more than once in peptide_predictions. Outputting two TSV files - one the predictions for peptides (in which peptide_id is nonunique) and the other the joined metadata dataframes (in which peptide_id is unique) - would avoid this. Outputting two would avoid duplication, but one might be easier to work with practically. We should assess this after running the pipeline a few times. if there is relatively little duplication in peptide_ids it might not matter in practice to separate these two files.

@taylorreiter
Copy link
Member Author

done in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant