Error in scaling factor calculations

[bttsmith]

I have a question concerning image scaling calculated starting in reader.py line 617.

On lines 628 and 632, the math is currently as follows: $[scale] = \frac{ [NumberOfElements] - 1}{[Length]}$

Why is the numerator $([NumberOfElements] - 1)$? As best I can tell, it should be only $[NumberOfElements]$.

When exporting images/videos through the Leica software, the included metadata calculates $Voxel = \frac{[Length]}{[NumberOfElements]}$, where voxel is equivalent to $1/[scale]$. There is no "-1" in the exported metadata.

The "-1" in readlif's code seems to introduce error into the scaling factors - is there something I am missing?

[ilorevilo]

I completely agree with you and mentioned this issue in #30 (comment).
Bioformats offers the option to calculate the scale in both ways to conserve some backwards compatibility (code and PR).