Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module recipe inconsistency #813

Open
KiwiHawk opened this issue Jun 29, 2022 · 7 comments
Open

Module recipe inconsistency #813

KiwiHawk opened this issue Jun 29, 2022 · 7 comments
Labels
Angels Bio Processing bio processing related Impact: Bug Something could be wrong

Comments

@KiwiHawk
Copy link
Collaborator

Mod list

  • Angel's Bioprocessing + prerequisites

Issue

All three tiers of Agriculture module require a green crystal. None of the other modules require crystals.

image

image

Fix Suggestions

Option 1:
Always add crystals to the recipe for Speed, Productivity and Efficiency modules. Not just when Industries Overhaul is active.

Option 2:
Remove crystals from agriculture modules. Only add crystals if Industries Overhaul is active.

@mecejide
Copy link

Didn’t all modules use to require crystals?

@KiwiHawk
Copy link
Collaborator Author

KiwiHawk commented Jun 29, 2022

Didn’t all modules use to require crystals?

Yes, if Industries overhaul is active. So not always.

@mecejide
Copy link

I thought in a previous version they did even without that.

@LovelySanta
Copy link
Collaborator

They should always require crystals when bio processing is active afaik? I believe otherwise crystals have no use?

@LovelySanta LovelySanta added Impact: Bug Something could be wrong Angels Bio Processing bio processing related labels Aug 7, 2022
@KiwiHawk
Copy link
Collaborator Author

KiwiHawk commented Aug 7, 2022

In Special vanilla, red and blue crystals have no use (so they are hidden). Green are used for agriculture modules.

I think either all the crystals should be hidden.
Or second option: none of the crystals get hidden. Crystals are added to all modules.

I prefer the second option. Else it seems like most of the mod will be disabled and hidden.

@LovelySanta
Copy link
Collaborator

I prefer creating a trigger for it, link it to a setting that is off by default for special vanilla, and gets overridden by angels industries overhaul

  1. Create trigger in bio data stage

  2. Set default value of trigger in bio data stage depending on bio setting

  3. Always create the crystal items/recipes (data stage)

  4. Disable crystals depending on trigger in data updates, or add crystals as ingredient to modules in the other case

@KiwiHawk
Copy link
Collaborator Author

Agriculture modules don't use the lower tier when Bob's modules is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angels Bio Processing bio processing related Impact: Bug Something could be wrong
Projects
None yet
Development

No branches or pull requests

3 participants