Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing resources prevent proper query parameter interpretation #106

Open
mmodrow opened this issue Aug 18, 2023 · 3 comments
Open

Missing resources prevent proper query parameter interpretation #106

mmodrow opened this issue Aug 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@mmodrow
Copy link
Contributor

mmodrow commented Aug 18, 2023

I tried to use cherry wood for a minecraft build, which is still missing. As the first cherry item was in the 2nd place of the query parameters (link created with the litematica plugin), only the first parameter was interpreted and then the rest was cut off.

See: https://resourcecalculator.com/minecraft/#dirt=80&strippedcherrylog=61&cherryslab=21&redstonedust=12&cherrytrapdoor=10&hopper=3&redstonecomparator=2&stickypiston=2&waterbucket=2&barrel=1&blockofredstone=1 (RaysWorks sniffer farm)

@AsherGlick
Copy link
Owner

Looks like we just dont gracefully handle malformed elements of the URI. We can skip over invalid elements, however they will still be stripped when the URI is next updated because it will be rebuilt from the internal state.

Screenshot from 2023-08-18 08-55-32

@AsherGlick AsherGlick added the bug Something isn't working label Aug 18, 2023
@mmodrow
Copy link
Contributor Author

mmodrow commented Aug 18, 2023

That would certainly be preferable over building a farm from 80 dirt only XD

@AsherGlick
Copy link
Owner

It is a dirt farm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants