Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceRevamp] Remove Negative Requirement Values #82

Open
Tracked by #76
AsherGlick opened this issue Jul 16, 2022 · 0 comments
Open
Tracked by #76

[ResourceRevamp] Remove Negative Requirement Values #82

AsherGlick opened this issue Jul 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@AsherGlick
Copy link
Owner

A relic from the original iteration of the code is that all of the requirements are negative values. This is due to how the solver works, by "adding" the negative requirements each iteration.

From the perspective of the resource list this makes no sense however. All the numbers should just be positive values to avoid having to add in all these extra - signs.

  Anvil:
    recipes:
    - output: 1
      recipe_type: Crafting
      requirements:
        Block of Iron: -3
        Iron Ingot: -4
    - recipe_type: Raw Resource

becomes

  Anvil:
    recipes:
    - output: 1
      recipe_type: Crafting
      requirements:
        Block of Iron: 3
        Iron Ingot: 4
    - recipe_type: Raw Resource

This will either require a change in the front end solver (ideal solution), or a change in the build script to emulate the negative values in the bundle that is sent to the front end.

@AsherGlick AsherGlick added the enhancement New feature or request label Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant